refactor: split NetworkEventListenerProvider

[lean-apple]

Closes #12861.

TODO:

• update network.md

[mattsse]

this looks great already.

will take a closer look once rfr, but this is exactly what we wanted.

I hope you didn't encounter too many conflicts while working on this -.-

[lean-apple]

this looks great already.

will take a closer look once rfr, but this is exactly what we wanted.

I hope you didn't encounter too many conflicts while working on this -.-

Thanks but I wonder if we can remove SessionEstablished from PeerEvent, and only have ActivePeerSession in NetworkEvent, otherwise there is always this double case if both events are emitted, and it can result in doing the same action, or do we need both ?

[mattsse]

Thanks but I wonder if we can remove SessionEstablished from PeerEvent, and only have ActivePeerSession in NetworkEvent

I think this is fine because we can easily a NetworkEvent into a PeerEvent

otherwise there is always this double case if both events are emitted, and it can result in doing the same action, or do we need both ?

but I think I get your point that this currently requires a another peer_events_sender channel?

since we can extract PeerEvent from NetworkEvent, we can avoid this if we change the Stream type that NetworkPeersEvents::event_listener returns.

we can introduce a helper wrapper type that holds Pin<Box<Stream Item = PeerEvent> + Send + Sync>

this way we can use the generic EventStream<NetworkEvent<R>>; but convert the NetworkEvent to PeerEvent, erasing the generic

[mattsse]

oh I think this is likely not necessary because peerEvent is a subset of of NetworkEvent now, so we can use the same event channel if we change the stream type

[mattsse]

instead of EventStream this could return a static BoxStream (or ideally a newtype wrapper) of EventStream<NetworkEvent>.map(Into)

[mattsse]

nice!

cc @Rjected this unblocks more progress on txmanager

[mattsse]

cool, nice additional cleanup