Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(rpc): create revm env on demand #13017

Merged
merged 8 commits into from
Nov 30, 2024
Merged

feat(rpc): create revm env on demand #13017

merged 8 commits into from
Nov 30, 2024

Conversation

lakshya-sky
Copy link
Contributor

Closes #12902

lakshya-sky
lakshya-sky commented Nov 29, 2024
View reviewed changes
Copy link
Contributor Author

@lakshya-sky lakshya-sky left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more. 

    /// The type that determines how to configure the EVM.
    evm_config: EvmConfig,

this is now unused should I make a method to return it and use it in EthState instead?

I've removed EvmConfig from EthStateCacheService completely.

@joshieDo joshieDo added C-enhancement New feature or request A-rpc Related to the RPC implementation labels Nov 29, 2024
@mattsse mattsse changed the title get env on demand feat(rpc): create revm env on demand Nov 30, 2024
mattsse
mattsse approved these changes Nov 30, 2024
View reviewed changes
Copy link
Collaborator

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ty!

I only renamed a few things

@mattsse mattsse requested a review from gakonst as a code owner November 30, 2024 16:42
@mattsse mattsse enabled auto-merge November 30, 2024 17:01
@mattsse mattsse added this pull request to the merge queue Nov 30, 2024
Merged via the queue into paradigmxyz:main with commit 890f082 Nov 30, 2024
42 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattsse mattsse mattsse approved these changes

@Rjected Rjected Awaiting requested review from Rjected Rjected is a code owner

@emhane emhane Awaiting requested review from emhane

@onbjerg onbjerg Awaiting requested review from onbjerg onbjerg is a code owner

@klkvr klkvr Awaiting requested review from klkvr klkvr is a code owner

@gakonst gakonst Awaiting requested review from gakonst gakonst is a code owner

Assignees
No one assigned
Labels
A-rpc Related to the RPC implementation C-enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Change evm_env_cache to header cache
3 participants
@lakshya-sky @mattsse @joshieDo