perf(trie): avoid (de)allocating an extra prefix set #13020
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hai-rise
requested review from
rkrasiuk,
Rjected and
shekhirin
as code owners
hai-rise
force-pushed
the
avoid-extra-alloc
branch
from
b15d4ce to
b1b6b71
Compare
mattsse
approved these changes
Nov 29, 2024
| #[cfg(feature = "metrics")] metrics: TrieRootMetrics, | ||
| ) -> Self { | ||
| Self { | ||
| trie_cursor_factory, | ||
| hashed_cursor_factory, | ||
| hashed_address, | ||
| prefix_set: PrefixSet::default(), | ||
| prefix_set, |
There was a problem hiding this comment.
I see, yeah this makes sense
mattsse
added
the
C-perf
rkrasiuk
approved these changes
Dec 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously we created
StorageRootwith aPrefixSet::Defaultonly to replace it immediately withwith_prefix_set. This extra (de)allocation is not cheap as it has anArcand is in the hot path of processing each leaf account node. We profiled live root calculation for new blocks with 10k-50k of account changes andStateRoot::calculatespent 1-2% of its time deallocating this extra prefix set. It is more expensive than RLP-encoding the accounts and ~25x more than #13004.