refactor: rename TransactionSignedEcRecovered to RecoveredTx
#13074
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
klkvr
requested review from
mattsse,
Rjected,
emhane,
fgimenez,
rakita and
rkrasiuk
as code owners
mattsse
requested changes
Dec 2, 2024
| pub const fn signer(&self) -> Address { | ||
| self.signer | ||
| } | ||
| pub type PooledTransactionsElementEcRecovered<T = PooledTransactionsElement> = RecoveredTx<T>; |
There was a problem hiding this comment.
could we also keep an alias for the TransactionSignedEcRecovered but mark it as deprecated, because I assume some people are using this type via reth-primitives
There was a problem hiding this comment.
also maybe we could rename PooledTransactionsElementEcRecovered to RecoveredPooledTx?
There was a problem hiding this comment.
also maybe we could rename
PooledTransactionsElementEcRecoveredtoRecoveredPooledTx?
I think ideally we just use RecoveredTx<PoolTx::Pooled>? the current PooledTransactionsElementEcRecovered is already not used much
Rjected
approved these changes
Dec 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will mostly be used with transaction generic so long type name isn't useful.
I've also made
PooledTransactionsElementEcRecoveredto just be a type alias forRecoveredTx<PooledTransactionsElement>:reth/crates/primitives/src/transaction/pooled.rs
Lines 690 to 691 in 4b6ee79