Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: propagate network primitives to on_command, on_network_event #13084

Merged
merged 1 commit into from
Dec 3, 2024

Conversation

Rjected
Copy link
Member

@Rjected Rjected commented Dec 2, 2024

Propagates the NetworkPrimitives generic in the TransactionsManager to the on_command and on_network_event methods, so that default types are not being used.

@Rjected Rjected added C-enhancement New feature or request A-tx-pool Related to the transaction mempool A-sdk Related to reth's use as a library labels Dec 2, 2024
Copy link
Collaborator

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mattsse
Copy link
Collaborator

mattsse commented Dec 3, 2024

rebasing after #13086

@Rjected Rjected force-pushed the dan/network-primitives-some-event-methods branch from b8718f2 to 730a97d Compare December 3, 2024 15:46
@Rjected Rjected added this pull request to the merge queue Dec 3, 2024
Merged via the queue into main with commit 64c6343 Dec 3, 2024
42 checks passed
@Rjected Rjected deleted the dan/network-primitives-some-event-methods branch December 3, 2024 16:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-sdk Related to reth's use as a library A-tx-pool Related to the transaction mempool C-enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants