chore: use BlockWithParent for StageError
#13198
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rjected
added
C-enhancement
Rjected
requested review from
onbjerg,
rkrasiuk,
shekhirin and
mattsse
as code owners
mattsse
reviewed
Dec 7, 2024
Actually yeah that would be better, will change stageerror to use that |
Rjected
force-pushed
the
dan/boxed-stage-error
branch
from
d3d6be4 to
568e404
Compare
Rjected
requested review from
joshieDo,
emhane,
klkvr,
fgimenez and
gakonst
as code owners
Rjected
force-pushed
the
dan/boxed-stage-error
branch
from
568e404 to
661e06c
Compare
Had to change the |
klkvr
requested changes
Dec 9, 2024
Rjected
changed the title
StageError variant in PipelineErrorBlockWithParent for StageError
mattsse
requested changes
Dec 10, 2024
Comment on lines
+147
to
+150
| block: Box::new(BlockWithParent::new( | ||
| header.parent_hash, | ||
| NumHash::new(header.number, header_hash), | ||
| )), |
There was a problem hiding this comment.
this can use the trait function I assume?
Comment on lines
+102
to
+109
| /// Generate a random [`BlockWithParent`]. | ||
| pub fn random_block_with_parent<R: Rng>( | ||
| rng: &mut R, | ||
| number: u64, | ||
| parent: Option<B256>, | ||
| ) -> BlockWithParent { | ||
| BlockWithParent { parent: parent.unwrap_or_default(), block: NumHash::new(number, rng.gen()) } | ||
| } |
There was a problem hiding this comment.
added alloy-rs/alloy#1777
mattsse
approved these changes
Dec 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #13197, changing to
BlockWithParentfor all of the fields that are currentlySealedHeaderinStageError