Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(db): make init_db function accepts a TableSet #13222

Merged
merged 1 commit into from
Dec 9, 2024
Merged

feat(db): make init_db function accepts a TableSet #13222

merged 1 commit into from
Dec 9, 2024

Conversation

alessandromazza98
Copy link
Contributor

@alessandromazza98 alessandromazza98 commented Dec 9, 2024 •
edited
Loading

Closes #13211

@mattsse

mattsse
mattsse requested changes Dec 9, 2024
View reviewed changes
Copy link
Collaborator

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this should not require any updates to existing code, like before we can solve this with an extra function

@alessandromazza98 alessandromazza98 force-pushed the ale/make-init-db-accept-tableset branch from 83e3eab to e5c374b Compare December 9, 2024 11:56
@mattsse mattsse enabled auto-merge December 9, 2024 12:05
@mattsse mattsse added this pull request to the merge queue Dec 9, 2024
Merged via the queue into paradigmxyz:main with commit 13302ca Dec 9, 2024
41 checks passed
@alessandromazza98 alessandromazza98 deleted the ale/make-init-db-accept-tableset branch December 9, 2024 12:51
@alessandromazza98
Copy link
Contributor Author

Hey @mattsse what do you think should be the next now? I think we are almost at the step to having to include a TableSet inside the node builder pattern in some way.

@alessandromazza98 alessandromazza98 mentioned this pull request Dec 9, 2024
Open
lean-apple pushed a commit to lean-apple/reth that referenced this pull request Dec 12, 2024
@alessandromazza98 @lean-apple
feat(db): make init_db function accepts a TableSet (paradigmxyz#13222)
6c1fad8
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattsse mattsse mattsse approved these changes

@rakita rakita Awaiting requested review from rakita rakita is a code owner

@joshieDo joshieDo Awaiting requested review from joshieDo joshieDo is a code owner

@shekhirin shekhirin Awaiting requested review from shekhirin

@onbjerg onbjerg Awaiting requested review from onbjerg

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Make db init function accept a tableset
2 participants
@alessandromazza98 @mattsse