Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(rpc): remove total difficulty #13303

Merged
merged 5 commits into from
Dec 12, 2024
Merged

feat(rpc): remove total difficulty #13303

merged 5 commits into from
Dec 12, 2024

Conversation

mvares
Copy link
Contributor

@mvares mvares commented Dec 11, 2024 •
edited
Loading

Closes #13297

mattsse
mattsse requested changes Dec 11, 2024
View reviewed changes
Copy link
Collaborator

@mattsse mattsse left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice, one suggestion.

cc @fgimenez in case this will trigger some hive errors, these are fine as per spec. geth also removed this already

crates/rpc/rpc-eth-api/src/helpers/block.rs Outdated Show resolved Hide resolved
@mattsse mattsse added the A-rpc Related to the RPC implementation label Dec 11, 2024
@mvares
Copy link
Contributor Author

mvares commented Dec 11, 2024

Probably, some tests can fail due to hive errors - as mentioned by matsse - but we can make some changes to resolve it

@mattsse mattsse mentioned this pull request Dec 11, 2024
Merged
@mattsse mattsse enabled auto-merge December 12, 2024 12:52
@mattsse mattsse added this pull request to the merge queue Dec 12, 2024
Merged via the queue into paradigmxyz:main with commit aca4a2d Dec 12, 2024
42 checks passed
@mvares mvares deleted the miguel/total-difficulty branch December 12, 2024 14:44
emhane pushed a commit to ethereum-optimism/op-reth that referenced this pull request Dec 13, 2024
@mvares @mattsse @emhane
feat(rpc): remove total difficulty (paradigmxyz#13303)
02f7643 
Co-authored-by: Matthias Seitz <[email protected]>
@fgimenez fgimenez mentioned this pull request Dec 17, 2024
Merged
@zilm13 zilm13 mentioned this pull request Dec 19, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattsse mattsse mattsse approved these changes

@Rjected Rjected Awaiting requested review from Rjected Rjected is a code owner

@emhane emhane Awaiting requested review from emhane

Assignees
No one assigned
Labels
A-rpc Related to the RPC implementation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove total difficulty from rpc
2 participants
@mvares @mattsse