Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: disable itertools default features #13500

Merged
merged 5 commits into from
Dec 22, 2024
Merged

chore: disable itertools default features #13500

merged 5 commits into from
Dec 22, 2024

Conversation

mattsse
Copy link
Collaborator

@mattsse mattsse commented Dec 22, 2024 •
edited
Loading

towards #13041

@mattsse mattsse requested a review from gakonst as a code owner December 22, 2024 18:34
@mattsse mattsse force-pushed the fix/disable-itertools-default-feature branch from 7657a13 to 2f99cd6 Compare December 22, 2024 18:36
@mattsse mattsse requested a review from onbjerg as a code owner December 22, 2024 18:47
@mattsse mattsse added the A-dependencies Pull requests or issues that are about dependencies label Dec 22, 2024
@mattsse mattsse mentioned this pull request Dec 22, 2024
Merged
@codspeed-hq CodSpeed HQ
Copy link

codspeed-hq bot commented Dec 22, 2024 •
edited
Loading

CodSpeed Performance Report

Merging #13500 will not alter performance

Comparing fix/disable-itertools-default-feature (497daa1) with main (0a5e430)

Summary

✅ 73 untouched benchmarks
🆕 4 new benchmarks
⁉️ 4 dropped benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark main fix/disable-itertools-default-feature Change
🆕 range lookup` N/A 613.6 µs N/A
🆕 any lookup` N/A 20.1 ms N/A
🆕 `prefix set preload size: 1000 input size: 1000 Vec with binary search lookup`
🆕 `prefix set preload size: 1000 input size: 1000 Vec with custom cursor lookup`
⁉️ range lookup` 613.5 µs N/A N/A
⁉️ any lookup` 19.9 ms N/A N/A
⁉️ `prefix set preload size: 1000 input size: 998 Vec with binary search lookup`
⁉️ `prefix set preload size: 1000 input size: 998 Vec with custom cursor lookup`

@mattsse mattsse merged commit 1d0bb3d into main Dec 22, 2024
42 of 43 checks passed
@mattsse mattsse deleted the fix/disable-itertools-default-feature branch December 22, 2024 19:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gakonst gakonst Awaiting requested review from gakonst gakonst is a code owner

@rkrasiuk rkrasiuk Awaiting requested review from rkrasiuk rkrasiuk is a code owner

@Rjected Rjected Awaiting requested review from Rjected Rjected is a code owner

@shekhirin shekhirin Awaiting requested review from shekhirin shekhirin is a code owner

@onbjerg onbjerg Awaiting requested review from onbjerg onbjerg is a code owner

Assignees
No one assigned
Labels
A-dependencies Pull requests or issues that are about dependencies
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@mattsse