Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: correct typo docs #13557

Merged
merged 5 commits into from
Dec 30, 2024
Merged

chore: correct typo docs #13557

Show file tree
Hide file tree
Changes from 4 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
57da491
Update error.rs
sky-coderay Dec 25, 2024
47e7445
Update lib.rs
sky-coderay Dec 25, 2024
7be714a
Update dao_fork.rs
sky-coderay Dec 25, 2024
921c91e
Update execute.rs
sky-coderay Dec 28, 2024
074d28d
Applied changes and formatting
futreall Dec 29, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion crates/consensus/beacon/src/engine/error.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@ impl From<DatabaseError> for BeaconConsensusEngineError {

/// Represents error cases for an applied forkchoice update.
///
/// This represents all possible error cases, that must be returned as JSON RCP errors back to the
/// This represents all possible error cases, that must be returned as JSON RPC errors back to the
/// beacon node.
#[derive(Debug, thiserror::Error)]
pub enum BeaconForkChoiceUpdateError {
Expand Down
2 changes: 1 addition & 1 deletion crates/engine/tree/src/lib.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,7 @@
//! ## Handling consensus messages
//!
//! Consensus message handling is performed by three main components:
//! 1. The [`EngineHandler`](engine::EngineHandler), which takes incoming consensus mesesages and
//! 1. The [`EngineHandler`](engine::EngineHandler), which takes incoming consensus messages and
//! manages any requested backfill or download work.
//! 2. The [`EngineApiRequestHandler`](engine::EngineApiRequestHandler), which processes messages
//! from the [`EngineHandler`](engine::EngineHandler) and delegates them to the
Expand Down
2 changes: 1 addition & 1 deletion crates/ethereum/evm/src/dao_fork.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ use alloy_primitives::{address, Address};
pub static DAO_HARDFORK_BENEFICIARY: Address = address!("bf4ed7b27f1d666546e30d74d50d173d20bca754");

/// DAO hardfork account that ether was taken and added to beneficiary
pub static DAO_HARDKFORK_ACCOUNTS: [Address; 116] = [
pub static DAO_HARDFORK_ACCOUNTS: [Address; 116] = [
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this rename has side effects. we also need to rename other occurrences of this constant

address!("d4fe7bc31cedb7bfb8a345f31e668033056b2728"),
address!("b3fb0e5aba0e20e5c49d252dfd30e102b171a425"),
address!("2c19c7f9ae8b751e37aeb2d93a699722395ae18f"),
Expand Down
4 changes: 2 additions & 2 deletions crates/ethereum/evm/src/execute.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
//! Ethereum block execution strategy.

use crate::{
dao_fork::{DAO_HARDFORK_BENEFICIARY, DAO_HARDKFORK_ACCOUNTS},
dao_fork::{DAO_HARDFORK_BENEFICIARY, DAO_HARDFORK_ACCOUNTS},
EthEvmConfig,
};
use alloc::{boxed::Box, sync::Arc, vec::Vec};
Expand Down Expand Up @@ -255,7 +255,7 @@ where
// drain balances from hardcoded addresses.
let drained_balance: u128 = self
.state
.drain_balances(DAO_HARDKFORK_ACCOUNTS)
.drain_balances(DAO_HARDFORK_ACCOUNTS)
.map_err(|_| BlockValidationError::IncrementBalanceFailed)?
.into_iter()
.sum();
Expand Down
Loading