chore(transaction-pool): remove duplicate code #13627
Open
+36
−19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattsse
previously approved these changes
Jan 3, 2025
Comment on lines
+5
to
+8
| pub(crate) fn match_versioned_hashes( | ||
| blob_sidecar: &BlobTransactionSidecar, | ||
| versioned_hashes: &[B256], | ||
| ) -> Vec<Option<BlobAndProofV1>> { |
There was a problem hiding this comment.
could you perhaps also upstream this to alloy and make this a function of BlobTransactionSidecar?
There was a problem hiding this comment.
i have PR to update here -> alloy-rs/alloy#1882
mattsse
added
C-debt
mattsse
dismissed
their stale review
actually, need to take a closer look at this
mattsse
requested changes
Jan 4, 2025
Comment on lines
+138
to
+139
| let matches = match_versioned_hashes(blob_sidecar, versioned_hashes); | ||
| for (i, match_result) in matches.into_iter().enumerate() { |
There was a problem hiding this comment.
this is a bit problematic because this now allocates let mut result = vec![None; versioned_hashes.len()]; per blob_sidecar
we can solve this differently:
|
@hoank101 this is blocked until next alloy release |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.