Avoiding infinite recursion in trait implementation #14261
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
comfsrt
requested review from
mattsse,
Rjected,
onbjerg and
klkvr
as code owners
mattsse
approved these changes
Feb 6, 2025
mattsse
reviewed
Feb 6, 2025
mattsse
added
C-bug
18aaddy
pushed a commit
to 18aaddy/reth
that referenced
this pull request
Feb 12, 2025
Co-authored-by: Matthias Seitz <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
/*
Changes:
Replaced:
Self::add_rlpx_sub_protocol(self, protocol)
with:
reth_network::NetworkManager::add_rlpx_sub_protocol(self, protocol)
Replaced:
self.secret_key()
with:
reth_network::NetworkManager::secret_key(self)
Reason:
These changes avoid infinite recursion by explicitly calling NetworkManager’s methods instead of the trait’s own implementation.
*/