perf(tree): state provider builder #14279
Merged
+82
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
namn-grg
force-pushed
the
chore/clone-state-provider
branch
from
3db0e67 to
2695011
Compare
Rjected
requested changes
Feb 6, 2025
crates/engine/tree/src/tree/mod.rs
Outdated
Comment on lines
443
to
456
| /// Returns a builder for creating state providers for the given hash. | ||
| /// | ||
| /// This is used to optimize state provider creation in parallel execution contexts. | ||
| pub fn state_provider_builder<P>( | ||
| &self, | ||
| provider: P, | ||
| hash: B256, | ||
| ) -> Option<StateProviderBuilder<N, P>> | ||
| where | ||
| P: BlockReader + StateProviderFactory + StateReader + StateCommitmentProvider + Clone, | ||
| { | ||
| let (historical, blocks) = self.blocks_by_hash(hash)?; | ||
| Some(StateProviderBuilder { provider, historical, blocks }) | ||
| } |
There was a problem hiding this comment.
I think we can remove this method and call self.blocks_by_hash + init the builder in the other state_provider_builder
There was a problem hiding this comment.
Hi just saw this thanks for review and fixing
|
also needs fmt |
|
taking over as this is urgent now |
Rjected
approved these changes
Feb 7, 2025
18aaddy
pushed a commit
to 18aaddy/reth
that referenced
this pull request
Feb 12, 2025
Co-authored-by: Dan Cline <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Introduces a cloneable state provider builder to optimize state provider creation by moving it out of the critical execution path.
Closes #14136