refactor: extract OP txpool types to a separate crate #14280
Merged
+639
−534
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
klkvr
requested review from
mattsse,
Rjected,
fgimenez and
gakonst
as code owners
mattsse
approved these changes
Feb 6, 2025
mattsse
reviewed
Feb 6, 2025
Comment on lines
+10
to
+11
| // The `optimism` feature must be enabled to use this crate. | ||
| #![cfg(feature = "optimism")] |
There was a problem hiding this comment.
yeah everything that uses revm + op still must be feature gated
|
Thanks for just republishing my work 👍 |
|
@hamdiallam really sorry for this, I didn't realize that your PR does the same thing as well I've added you as a coauthor to #14249 as it was similar but with different approach, but didn't notice you've moved txpool types too :/ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
for tx conditionals we'd need access to pool traits/types from payload builder crate which means we can no longer have those in reth-optimism-node