refactor: remove PostExecutionInput
#14464
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
klkvr
force-pushed
the
klkvr/rm-post-exec-input
branch
from
3d3c837 to
b7e99df
Compare
klkvr
force-pushed
the
klkvr/rm-post-exec-input
branch
2 times, most recently
from
4432a7b to
1c5131d
Compare
emhane
approved these changes
Feb 13, 2025
There was a problem hiding this comment.
good! a big improvement is if linking to issues was better, so that it would be visible from looking at prs how they tie into the higher level features currently being developed for reth/op-reth. that way it would be visible that the work you're doing often has big impact, and is not just a drive-by debt clean up.
this pr unblocks l2 withdrawals validation post execution for isthmus
Comment on lines
-30
to
-45
| /// Post execution input passed to [`FullConsensus::validate_block_post_execution`]. | ||
| #[derive(Debug)] | ||
| pub struct PostExecutionInput<'a, R> { | ||
| /// Receipts of the block. | ||
| pub receipts: &'a [R], | ||
| /// EIP-7685 requests of the block. | ||
| pub requests: &'a Requests, | ||
| } | ||
|
|
||
| impl<'a, R> PostExecutionInput<'a, R> { | ||
| /// Creates a new instance of `PostExecutionInput`. | ||
| pub const fn new(receipts: &'a [R], requests: &'a Requests) -> Self { | ||
| Self { receipts, requests } | ||
| } | ||
| } | ||
|
|
There was a problem hiding this comment.
nice, this unblocks l2 withdrawals validation post execution
mattsse
approved these changes
Feb 13, 2025
.github/assets/check_rv32imac.sh
Outdated
Comment on lines
13
to
17
| reth-prune-types | ||
| reth-static-file-types | ||
| reth-storage-errors | ||
| reth-execution-errors | ||
| reth-execution-types |
|
pending conflicts |
klkvr
force-pushed
the
klkvr/rm-post-exec-input
branch
from
6162ca7 to
fd9ed72
Compare
frankudoags
pushed a commit
to frankudoags/reth
that referenced
this pull request
Feb 13, 2025
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on #14465
Eventually it might be valuable for
Consensusto operate directly on types produced by block executor.This PR removes
PostExecutionInputin favor of usingreth_execution_types::BlockExecutionResultdirectly.BlockExecutionOutputis changed to contain aBlockExecutionResultdirectly, essentially making it similar toResultAndState. The expectation is that once we have a usecase for custom block executor output we'd just abstract components overBlockExecutionResult