chore: more work on filter #1468
Conversation
| let address_filter = FilteredParams::address_filter(&filter.address); | ||
| let topics_filter = FilteredParams::topics_filter(&topics); | ||
|
|
||
| for block_number in from_block..=to_block { |
There was a problem hiding this comment.
just checked that the range is indeed inclusive
https://github.com/ethereum/go-ethereum/blob/f86f04864603d4d1398e134fae319531453b67e9/core/bloombits/matcher.go#L193
| { | ||
| self.append_matching_block_logs(&mut logs, &filter_params, block); | ||
|
|
||
| // TODO size check |
There was a problem hiding this comment.
yes, can't check number of logs yet.
Codecov Report
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more @@ Coverage Diff @@
## main #1468 +/- ##
==========================================
- Coverage 75.96% 75.94% -0.02%
==========================================
Files 358 358
Lines 42689 42686 -3
==========================================
- Hits 32428 32420 -8
- Misses 10261 10266 +5
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
impl remaining filter changes
realized progress is blocked until we can fetch logs.
would like to merge this as is