feat: implement eth handshake disconnects #1494
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rjected
added
C-enhancement
Codecov Report
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more @@ Coverage Diff @@
## main #1494 +/- ##
==========================================
- Coverage 76.00% 75.94% -0.06%
==========================================
Files 358 358
Lines 42660 42689 +29
==========================================
- Hits 32423 32422 -1
- Misses 10237 10267 +30
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
mattsse
approved these changes
Feb 22, 2023
Comment on lines
+159
to
+160
| async fn disconnect( | ||
| &mut self, |
There was a problem hiding this comment.
using mut borrow is fine I guess, mimicks what TcpStream::shutdown does as well.
and we likely need this mut borrow if we want to use it in Sink/Stream impls
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This implements disconnects in the eth handshake by introducing the
CanDisconnecttrait, following the design in #1492The trait extends
Sink<T>, with Default implementations forECIESStreamand allFramed<T, U>that implementSink. These implementations just close the sink usingSinkExt::close.