Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

perf(rpc): add optional block hash arg #1502

Merged
merged 1 commit into from
Feb 22, 2023
Merged

perf(rpc): add optional block hash arg #1502

merged 1 commit into from
Feb 22, 2023

Conversation

mattsse
Copy link
Collaborator

@mattsse mattsse commented Feb 22, 2023

add optional block hash arg instead always computing the hash

@mattsse mattsse requested a review from gakonst as a code owner February 22, 2023 12:47
@mattsse mattsse added the A-rpc Related to the RPC implementation label Feb 22, 2023
@mattsse mattsse requested a review from rkrasiuk February 22, 2023 12:48
@mattsse mattsse added the C-perf A change motivated by improving speed, memory usage or disk footprint label Feb 22, 2023
rkrasiuk
rkrasiuk approved these changes Feb 22, 2023
View reviewed changes
Copy link
Member

@rkrasiuk rkrasiuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mattsse mattsse merged commit 281f139 into main Feb 22, 2023
@mattsse mattsse deleted the matt/add-opt-blockhash branch February 22, 2023 13:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rkrasiuk rkrasiuk rkrasiuk approved these changes

@gakonst gakonst Awaiting requested review from gakonst

Assignees
No one assigned
Labels
A-rpc Related to the RPC implementation C-perf A change motivated by improving speed, memory usage or disk footprint
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mattsse @rkrasiuk