Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(docs): fix install command #1503

Merged
merged 1 commit into from
Feb 22, 2023
Merged

fix(docs): fix install command #1503

merged 1 commit into from
Feb 22, 2023

Conversation

mattsse
Copy link
Collaborator

@mattsse mattsse commented Feb 22, 2023

cargo install uses release profile by default and --path --bin does not work in workspaces

ref rust-lang/cargo#7124

Closes #1501

@mattsse mattsse requested a review from gakonst as a code owner February 22, 2023 12:55
@mattsse mattsse added the C-docs An addition or correction to our documentation label Feb 22, 2023
@mattsse mattsse force-pushed the matt/rm-wrong-release-arg branch from 059cd0a to e376eca Compare February 22, 2023 12:55
@codecov-commenter
Copy link

codecov-commenter commented Feb 22, 2023

Codecov Report

Merging #1503 (e376eca) into main (44e1d13) will decrease coverage by 0.03%.
The diff coverage is n/a.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@            Coverage Diff             @@
##             main    #1503      +/-   ##
==========================================
- Coverage   76.14%   76.12%   -0.03%     
==========================================
  Files         358      358              
  Lines       42706    42706              
==========================================
- Hits        32520    32509      -11     
- Misses      10186    10197      +11     
Flag Coverage Δ
integration-tests 21.84% <ø> (+<0.01%) ⬆️
unit-tests 70.50% <ø> (-0.12%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
crates/net/discv4/src/proto.rs 89.66% <0.00%> (-3.13%) ⬇️
crates/net/discv4/src/lib.rs 66.01% <0.00%> (-0.22%) ⬇️
crates/net/network/src/peers/manager.rs 82.46% <0.00%> (-0.09%) ⬇️
crates/net/downloaders/src/headers/task.rs 83.67% <0.00%> (ø)
crates/net/network/src/manager.rs 52.49% <0.00%> (+0.18%) ⬆️
crates/net/eth-wire/src/ethstream.rs 84.44% <0.00%> (+0.47%) ⬆️
crates/stages/src/stages/hashing_storage.rs 96.19% <0.00%> (+0.54%) ⬆️
crates/net/downloaders/src/bodies/task.rs 96.59% <0.00%> (+1.13%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@rkrasiuk rkrasiuk merged commit 9be76ca into main Feb 22, 2023
@rkrasiuk rkrasiuk deleted the matt/rm-wrong-release-arg branch February 22, 2023 14:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-docs An addition or correction to our documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

In documentation, wrong installation commands when building from source
3 participants