Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(docs): add command name as docs #1505

Merged
merged 1 commit into from
Feb 22, 2023
Merged

chore(docs): add command name as docs #1505

merged 1 commit into from
Feb 22, 2023

Conversation

mattsse
Copy link
Collaborator

@mattsse mattsse commented Feb 22, 2023

add the command name as docstring, this helps when searching for the implementation via command name

@mattsse mattsse requested a review from gakonst as a code owner February 22, 2023 13:08
@mattsse mattsse added the C-docs An addition or correction to our documentation label Feb 22, 2023
@mattsse mattsse requested a review from rkrasiuk February 22, 2023 13:08
@codecov-commenter
Copy link

codecov-commenter commented Feb 22, 2023

Codecov Report

Merging #1505 (4cd7750) into main (2e73463) will decrease coverage by 0.01%.
The diff coverage is n/a.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@            Coverage Diff             @@
##             main    #1505      +/-   ##
==========================================
- Coverage   76.08%   76.07%   -0.01%     
==========================================
  Files         358      358              
  Lines       42720    42720              
==========================================
- Hits        32502    32498       -4     
- Misses      10218    10222       +4     
Flag Coverage Δ
integration-tests 21.83% <ø> (-0.04%) ⬇️
unit-tests 70.54% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
crates/rpc/rpc/src/eth/api/server.rs 98.96% <ø> (ø)
crates/net/network/src/session/active.rs 84.74% <0.00%> (-0.60%) ⬇️
crates/stages/src/stages/sender_recovery.rs 90.95% <0.00%> (-0.54%) ⬇️
crates/net/network/src/manager.rs 52.49% <0.00%> (+0.18%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@mattsse mattsse merged commit 81fec4b into main Feb 22, 2023
@mattsse mattsse deleted the matt/docs-add-handlers branch February 22, 2023 13:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-docs An addition or correction to our documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants