feat(rpc): impl uncle count handlers #1511
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattsse
added
C-enhancement
gakonst
approved these changes
Feb 22, 2023
| block_id: impl Into<BlockId>, | ||
| ) -> EthResult<Option<Vec<reth_primitives::Header>>> { | ||
| let block_id = block_id.into(); | ||
| Ok(self.client().ommers(block_id)?) |
There was a problem hiding this comment.
Starting to think we should have the API operate an LRU cache of all of these historical queries, so we avoid going to the db
There was a problem hiding this comment.
Should we have something like LRU per table?
There was a problem hiding this comment.
if we add this to the Database/StateProvider directly, we'd need a sync primitive for the cache which could do more harm than good.
for RPC, I was thinking about adding a Task that has an LRU but communicates via a channel.
So the workflow would be something like:
- RPC request comes in
- needs block x
- sends Command to fetch block x to the cache task
- cache task looks up LRU or fetches from DB sends response back
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
impls
change return type to option. should return null for not found
ref #1225