Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add encoded_length to ValidPoolTransaction #1512

Merged
merged 1 commit into from
Feb 22, 2023

Conversation

leruaa
Copy link
Contributor

@leruaa leruaa commented Feb 22, 2023

#1500 followup.

@mattsse any hint on where this new encoded_length should be used?

@leruaa leruaa requested a review from mattsse as a code owner February 22, 2023 15:00
@leruaa leruaa changed the title Add encoded_length to ValidPoolTransaction feat: add encoded_length to ValidPoolTransaction Feb 22, 2023
Copy link
Collaborator

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

we need this for #1484

@mattsse
Copy link
Collaborator

mattsse commented Feb 22, 2023

we can also change what fn size returns and use the encoded_length instead, because this is more accurate than the num of bytes of the tx data.

@mattsse mattsse added C-enhancement New feature or request A-tx-pool Related to the transaction mempool labels Feb 22, 2023
@codecov-commenter
Copy link

codecov-commenter commented Feb 22, 2023

Codecov Report

Merging #1512 (359703a) into main (8094ab1) will increase coverage by 0.00%.
The diff coverage is 100.00%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@           Coverage Diff           @@
##             main    #1512   +/-   ##
=======================================
  Coverage   76.07%   76.07%           
=======================================
  Files         358      358           
  Lines       42759    42764    +5     
=======================================
+ Hits        32528    32534    +6     
+ Misses      10231    10230    -1     
Flag Coverage Δ
integration-tests 21.83% <40.00%> (+0.01%) ⬆️
unit-tests 70.54% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
crates/transaction-pool/src/pool/mod.rs 45.33% <100.00%> (+0.46%) ⬆️
crates/transaction-pool/src/test_utils/mock.rs 68.15% <100.00%> (+1.25%) ⬆️
crates/transaction-pool/src/validate.rs 52.23% <100.00%> (+0.72%) ⬆️
crates/net/network/src/session/mod.rs 76.59% <0.00%> (-1.36%) ⬇️
crates/stages/src/stages/sender_recovery.rs 90.95% <0.00%> (-0.54%) ⬇️
crates/stages/src/stages/hashing_storage.rs 95.65% <0.00%> (-0.28%) ⬇️
crates/net/discv4/src/lib.rs 66.23% <0.00%> (+0.07%) ⬆️
crates/net/eth-wire/src/ethstream.rs 84.21% <0.00%> (+0.23%) ⬆️
crates/net/network/src/session/active.rs 85.33% <0.00%> (+0.74%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@mattsse mattsse merged commit fdff1b0 into paradigmxyz:main Feb 22, 2023
@leruaa leruaa deleted the cache_encoded_length branch July 12, 2024 18:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-tx-pool Related to the transaction mempool C-enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants