Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove unused crate deps #1524

Merged
merged 1 commit into from
Feb 23, 2023
Merged

chore: remove unused crate deps #1524

merged 1 commit into from
Feb 23, 2023

Conversation

mattsse
Copy link
Collaborator

@mattsse mattsse commented Feb 23, 2023

remove unused deps

@mattsse mattsse requested a review from rkrasiuk February 23, 2023 11:04
@mattsse mattsse added C-debt A clean up/refactor of existing code A-dependencies Pull requests or issues that are about dependencies labels Feb 23, 2023
@mattsse mattsse force-pushed the matt/cleanup-provider branch from 769ddae to 0aa114e Compare February 23, 2023 11:25
@codecov-commenter
Copy link

codecov-commenter commented Feb 23, 2023

Codecov Report

Merging #1524 (0aa114e) into main (3c77dd9) will decrease coverage by 11.46%.
The diff coverage is 100.00%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@             Coverage Diff             @@
##             main    #1524       +/-   ##
===========================================
- Coverage   75.75%   64.29%   -11.46%     
===========================================
  Files         361      362        +1     
  Lines       42927    42957       +30     
===========================================
- Hits        32518    27619     -4899     
- Misses      10409    15338     +4929     
Flag Coverage Δ
integration-tests 21.76% <0.00%> (-0.03%) ⬇️
unit-tests 58.13% <100.00%> (-12.10%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
crates/storage/provider/src/lib.rs 100.00% <100.00%> (ø)
crates/interfaces/src/p2p/priority.rs 0.00% <0.00%> (-100.00%) ⬇️
crates/net/network-api/src/reputation.rs 0.00% <0.00%> (-100.00%) ⬇️
crates/storage/libmdbx-rs/src/lib.rs 4.54% <0.00%> (-95.46%) ⬇️
...storage/provider/src/providers/state/historical.rs 0.00% <0.00%> (-91.90%) ⬇️
bin/reth/src/test_eth_chain/models.rs 11.06% <0.00%> (-69.03%) ⬇️
crates/net/discv4/src/test_utils.rs 21.71% <0.00%> (-66.97%) ⬇️
crates/primitives/src/proofs.rs 30.73% <0.00%> (-66.40%) ⬇️
crates/stages/src/pipeline/event.rs 40.00% <0.00%> (-60.00%) ⬇️
crates/transaction-pool/src/pool/state.rs 30.35% <0.00%> (-53.58%) ⬇️
... and 104 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@mattsse mattsse merged commit a3067d9 into main Feb 23, 2023
@mattsse mattsse deleted the matt/cleanup-provider branch February 23, 2023 11:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-dependencies Pull requests or issues that are about dependencies C-debt A clean up/refactor of existing code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants