-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
include apache licenced fastrlp as reth-rlp #63
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
no authors in the original: https://docs.rs/crate/fastrlp/0.1.2/source/Cargo.toml.orig
should we make a note in the readme?
Will add the note |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sounds good. We'll need to derive this in ethers core types though? If we're doing this, maybe we should just sprint on ruint
usage over Primitive Types & Ethers Core? And get this fastrlp there?
* add l1_fee field to `Receipt` Signed-off-by: Gregory Edison <[email protected]> * scroll consensus Signed-off-by: Gregory Edison <[email protected]> * feat: scroll execution strategy Signed-off-by: Gregory Edison <[email protected]> * feat: expose `verify_receipts` from reth-ethereum-consensus Signed-off-by: Gregory Edison <[email protected]> * feat: add `reth-scroll-evm` crate to avoid cyclic dep Signed-off-by: Gregory Edison <[email protected]> * improve curie fork application + test Signed-off-by: Gregory Edison <[email protected]> * integrate l1 fee Signed-off-by: Gregory Edison <[email protected]> * add `ScrollEvmConfig` Signed-off-by: Gregory Edison <[email protected]> * add tests for `ScrollEvmConfig` Signed-off-by: Gregory Edison <[email protected]> * add tests for `ScrollExecutionStrategy` Signed-off-by: Gregory Edison <[email protected]> * add l1 message test for `ScrollExecutionStrategy` Signed-off-by: Gregory Edison <[email protected]> * add legacy tx execution test for `ScrollExecutionStrategy` Signed-off-by: Gregory Edison <[email protected]> * use revm scroll fork Signed-off-by: Gregory Edison <[email protected]> * introduce `ScrollExecutionStrategyFactory` Signed-off-by: Gregory Edison <[email protected]> * feat: patch revm crate to scroll fork Signed-off-by: Gregory Edison <[email protected]> * fix: lints Signed-off-by: Gregory Edison <[email protected]> * fix: deny Signed-off-by: Gregory Edison <[email protected]> * answer comments Signed-off-by: Gregory Edison <[email protected]> * fill `TxEnv.rlp_bytes` only for !is_l1_message Signed-off-by: Gregory Edison <[email protected]> * lints Signed-off-by: Gregory Edison <[email protected]> * switch revm to scroll default branch Signed-off-by: Gregory Edison <[email protected]> * fix: deny Signed-off-by: Gregory Edison <[email protected]> * fix: remove alloy-sol-types patch Signed-off-by: Gregory Edison <[email protected]> * feat: propagate scroll chain spec in execution Signed-off-by: Gregory Edison <[email protected]> * fix: scroll ci Signed-off-by: Gregory Edison <[email protected]> * chore: bump `trust-dns-resolver` to 0.25 alpha4 to fix deny Signed-off-by: Gregory Edison <[email protected]> * fix: propagate serde feature Signed-off-by: Gregory Edison <[email protected]> * fix: docs Signed-off-by: Gregory Edison <[email protected]> * answer comments Signed-off-by: Gregory Edison <[email protected]> * lint Signed-off-by: Gregory Edison <[email protected]> * answer comments Signed-off-by: Gregory Edison <[email protected]> --------- Signed-off-by: Gregory Edison <[email protected]>
Including apache licenced fastrlp from here: https://docs.rs/fastrlp/0.1.2/fastrlp/index.html
Bloom filters need to be enabled behind
ethereum-types
, they are not commented out.