Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add EIP-7702 support #8895

Closed
wants to merge 1 commit into from
Closed

Conversation

lattejed
Copy link
Contributor

@lattejed lattejed commented Jun 17, 2024

Sharing our work for adding EIP-7702 transaction support to reth / revm / alloy

Current state:

  • 7702 transaction support has been added to reth and alloy
  • EOA code loading has been added to revm but full 7702 execution has not been tested yet
  • The teardown of 7702 transactions in revm has not been added yet
  • Gas calculations have not been updated and are not correct
  • Compact encoding of added types in reth is currently byte-for-byte
  • Overall correctness needs to be checked
  • Not all tests have been added or updated

Incomplete items and points of discussion are marked with TODO(eip7702)

If you have any questions about any of this work let us know

The three related PRs:

#8895
bluealloy/revm#1541
alloy-rs/alloy#928

Copy link
Member

@Rjected Rjected left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one comment about the compact encoding, although would help if @joshieDo were to take a look

use alloy_primitives::{Address, U256};
use bytes::{Buf, BufMut};

impl Compact for Authorization {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we probably want something like withdrawal:

/// Withdrawal acts as bridge which simplifies Compact implementation for AlloyWithdrawal.
///
/// Notice: Make sure this struct is 1:1 with `alloy_eips::eip4895::Withdrawal`
#[main_codec]
#[derive(Debug, Clone, PartialEq, Eq, Default)]

derives are usually less error prone than a manual compact impl like this, and handle optionals properly

@onbjerg onbjerg mentioned this pull request Jul 1, 2024
@onbjerg
Copy link
Collaborator

onbjerg commented Jul 1, 2024

Closed in favor of #9214

@onbjerg onbjerg closed this Jul 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants