Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: extract configuration types to reth-network-types #9136

Merged
merged 6 commits into from
Jun 27, 2024
Merged

refactor: extract configuration types to reth-network-types #9136

merged 6 commits into from
Jun 27, 2024

Conversation

klkvr
Copy link
Collaborator

@klkvr klkvr commented Jun 27, 2024 •
edited
Loading

Closes #8418

Extracts PeersConfig and SessionConfig to new crate reth-network-types and removes reth-network dependency from reth-config

I've extracted ConnectionsConfig from ConnectionInfo as it seemed reasonable and allowed to keep ConnectionInfo in reth-network. Besides that, other types were moved as-is.

mattsse
mattsse approved these changes Jun 27, 2024
View reviewed changes
Copy link
Collaborator

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clean!

crates/net/network/src/peers.rs
Comment on lines +932 to +933
/// Restrictions on number of connections.
config: ConnectionsConfig,
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is a lot cleaner

crates/config/Cargo.toml
@@ -12,7 +12,7 @@ workspace = true

[dependencies]
# reth
reth-network.workspace = true
reth-network-types = { workspace = true, features = ["serde"] }
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

perfect

@mattsse mattsse added C-debt Refactor of code section that is hard to understand or maintain A-networking Related to networking in general labels Jun 27, 2024
@mattsse mattsse added this pull request to the merge queue Jun 27, 2024
Merged via the queue into paradigmxyz:main with commit 18eef6a Jun 27, 2024
32 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattsse mattsse mattsse approved these changes

@emhane emhane Awaiting requested review from emhane

@Rjected Rjected Awaiting requested review from Rjected Rjected is a code owner

@onbjerg onbjerg Awaiting requested review from onbjerg onbjerg is a code owner

@gakonst gakonst Awaiting requested review from gakonst gakonst is a code owner

Assignees
No one assigned
Labels
A-networking Related to networking in general C-debt Refactor of code section that is hard to understand or maintain
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Move reth-network config types to new crate network-types
2 participants
@klkvr @mattsse