Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AST validate unchecked nested blocks #116

Merged
merged 6 commits into from
Nov 14, 2024
Merged

AST validate unchecked nested blocks #116

merged 6 commits into from
Nov 14, 2024

Conversation

ferranbt
Copy link
Contributor

This PR adds an AST validation to check for nested unchecked blocks.

DaniPopes
DaniPopes reviewed Nov 13, 2024
View reviewed changes
Copy link
Member

@DaniPopes DaniPopes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! One nit

crates/sema/src/ast_passes.rs Outdated Show resolved Hide resolved
tests/ui/typeck/unchecked_block.sol Outdated Show resolved Hide resolved
@0xalpharush 0xalpharush mentioned this pull request Nov 14, 2024
Open
@DaniPopes DaniPopes merged commit f204dca into paradigmxyz:main Nov 14, 2024
11 checks passed
@DaniPopes DaniPopes mentioned this pull request Nov 14, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DaniPopes DaniPopes DaniPopes approved these changes

@onbjerg onbjerg Awaiting requested review from onbjerg onbjerg is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ferranbt @DaniPopes