Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: enable more Yul tests #83

Merged
merged 1 commit into from
Oct 21, 2024
Merged

test: enable more Yul tests #83

merged 1 commit into from
Oct 21, 2024

Conversation

DaniPopes
Copy link
Member

Enable more Yul tests by removing the has_typed_identifier check. This is done because typed identifiers have been removed with ethereum/solidity#15329.

from

test result: ok. 233 passed; 878 filtered out

to

test result: ok. 1051 passed; 60 filtered out

@DaniPopes DaniPopes requested a review from onbjerg as a code owner October 20, 2024 21:10
@DaniPopes DaniPopes enabled auto-merge (squash) October 20, 2024 21:15
@DaniPopes DaniPopes merged commit bb2719a into main Oct 21, 2024
11 checks passed
@DaniPopes DaniPopes deleted the dani/more-yul branch October 21, 2024 01:05
@DaniPopes DaniPopes added the C-test Category: a change that impacts how or what we test label Oct 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@onbjerg onbjerg onbjerg approved these changes

Assignees
No one assigned
Labels
C-test Category: a change that impacts how or what we test
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@DaniPopes @onbjerg