Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Simplesim log subscribing #325

Merged
merged 2 commits into from
Jan 20, 2024
Merged

Simplesim log subscribing #325

merged 2 commits into from
Jan 20, 2024

Conversation

Jaromel-Tuzerad
Copy link
Contributor

Adds logging subcribing to topics to simplesim, when using --verbose

@Jaromel-Tuzerad Jaromel-Tuzerad marked this pull request as ready for review January 18, 2024 12:49
@Ondraceq
Copy link
Contributor

The createFormattedString should be called something like loggingEnabled - and should have a comment that it is used for optimizing out the creation of the string in case the logs are disabled...
But this is not your code, so you can do that but don't have to.

@Jaromel-Tuzerad Jaromel-Tuzerad merged commit ef28301 into master Jan 20, 2024
20 checks passed
@Jaromel-Tuzerad Jaromel-Tuzerad deleted the simplesimLogSubscribe branch January 20, 2024 09:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ondraceq Ondraceq Ondraceq approved these changes

@yaqwsx yaqwsx Awaiting requested review from yaqwsx

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Jaromel-Tuzerad @Ondraceq