Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Install latest version of gopls #191

Closed
wants to merge 1 commit into from

Conversation

seankimkdy
Copy link
Collaborator

@seankimkdy seankimkdy commented Apr 10, 2024

Previous versions of gopls used to have an issue with build tags (see deleted README section for more details). This was resolved in v0.15 according to golang/go#29202 (we used to have v0.12 that got installed through gotestsum). Nevermind turns out it's not actually fix.

@seankimkdy seankimkdy requested a review from smcclure20 April 10, 2024 01:38
Copy link

github-actions bot commented Apr 10, 2024

Unit Test Results

232 tests  ±0   232 ✅ ±0   2s ⏱️ ±0s
 45 suites ±0     0 💤 ±0 
  1 files   ±0     0 ❌ ±0 

Results for commit 6395883. ± Comparison against base commit 4157649.

♻️ This comment has been updated with latest results.

@seankimkdy seankimkdy force-pushed the seankimkdy/gopls-update-build-tags branch from 230d703 to 6395883 Compare April 10, 2024 01:42
Copy link

46.6

For the detailed report, please go to Checks tab, click Build and Test, and then download unit_test_coverage artifact at the bottom of build page.

  • Your PR branch coverage: 46.6 %
  • main branch coverage: 0 %
  • diff coverage: 46.6 %

The coverage result does not include the functional test results.

@seankimkdy
Copy link
Collaborator Author

Nevermind turns out it's not fixed.

@seankimkdy seankimkdy closed this Apr 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant