Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proposal: Streaming Ed25519 verification #23

Merged
merged 2 commits into from
Jan 20, 2017
Merged

Conversation

paragonie-scott
Copy link
Member

To reduce the memory requirements for Ed25519 verification, we use a streaming API to calculate the same result. I'm not confident that this should be included in v0.3.0, but some projects may desire this if v1.0.0 is ever tagged.

@paragonie-scott paragonie-scott merged commit 865a35f into master Jan 20, 2017
@paragonie-scott paragonie-scott deleted the file-util branch January 20, 2017 02:09
@paragonie-scott
Copy link
Member Author

@dd32 indicated that WordPress would absolutely want this for WP providers that are just barely scraping by with their memory limits. In the future, I'll look into adding streaming auth(), box(), box_seal(), secretbox(), and their respective open/verify API methods. No promises that it will land in v1.0.0!

@dd32
Copy link

dd32 commented Jan 20, 2017

It wouldn't be a deal-breaker for WordPress, but the option would be greatly appreciated by others I'm sure.
When dealing with signatures, signing a file without having to pull the contents into memory first just seems expected (to me).

@paragonie-scott
Copy link
Member Author

That's why I wrote ParagonIE\Halite\File :)

Okay, I'm going to do a quick internal code review then tag v0.3.0 and focus on #8 -- if you know anyone at Automattic to talk to about that, please send them my way.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants