Massive Formatting Overhaul #7
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains a significant number of changes to DendroLib (aka Dendro-5.01).
The project suffered from massive inconsistency with its formatting, where some code was formatted, some of it wasn't, and much of the formatting was inconsistent. Many lines went well beyond 200+ characters, indentation was all over, and other issues. The code is still excellent, but reading through it with the inconsistencies was tough, especially for people unfamiliar with what it does.
I've created a uniform clang-format file and have applied it to all Dendro-based source files (things like zlib and other included libraries are not formatted).
This will make comparing history odd when looking for particular changes past this particular set of changes, but I feel this is a must in order to better read the code and work on the project going forward.