Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dependency updates (wgpu 0.13) #289

Closed
wants to merge 11 commits into from
Closed

Dependency updates (wgpu 0.13) #289

wants to merge 11 commits into from

Conversation

JMS55
Copy link
Contributor

@JMS55 JMS55 commented Jul 18, 2022

Initial work towards wgpu 0.13.

builder.rs::get_texture_format_size() needs updating.
So does the egui example.

I'm also not sure if we're handling the surface_texture_format correctly or not.

Git seems to have gotten confused - I guess that's what I get for forgetting to rebase my fork :/. I need to fix this.

JMS55 and others added 11 commits February 5, 2022 18:38
* Update dependencies

- Closes parasyte#270

* Unify controls in Invaders example

The fire button on gamepads was allowing trapid fire when holding the
button. Keyboard controls required the fire key to be released between
each shot fired. This commit fixes the difference by making the gamepad
fire button act like the keyboard fire key.
* Update egui to 0.18

- Closes parasyte#278

* Bump MSRV to 1.60.0 for egui
@parasyte
Copy link
Owner

egui-wgpu is has been updated to 0.13. We'll have to use a git path until it is released. So, the demo should not be much trouble to update!

The texture format size can be daunting, but the math tends to be pretty easy. I usually just read through the type docs to figure out what's new or changed, and cross-reference with wikipedia or some other doc sources for the compressed formats.

I'm also not sure if we're handling the surface_texture_format correctly or not.

Do you have any more info on this? What might need correcting here?

@Zageron
Copy link
Contributor

Zageron commented Jul 29, 2022

Hey there, any update on a possible resolution to this? Anything I can do?
Thanks for all the hard work!

@JMS55
Copy link
Contributor Author

JMS55 commented Jul 29, 2022

Unfortunately I've gotten quite busy, and do not know when I'll have time to finish this PR. Feel free to pick up where I left off. Iirc there's not a ton left, just the stuff I talked about in the first comment.

@parasyte parasyte mentioned this pull request Aug 17, 2022
@parasyte
Copy link
Owner

This work will be continued in #300 with a clean rebased history. Thank you!

@parasyte parasyte closed this Aug 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants