Overwrite sass imports with parcel's resolver #1256
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1256 +/- ##
==========================================
+ Coverage 85.86% 88.38% +2.52%
==========================================
Files 77 77
Lines 4307 4192 -115
==========================================
+ Hits 3698 3705 +7
+ Misses 609 487 -122
Continue to review full report at Codecov.
|
| resolver.resolve(url, prev === 'stdin' ? this.name : prev) | ||
| ).path; | ||
| } catch (e) { | ||
| resolved = url; |
There was a problem hiding this comment.
does this fall back to the default SASS resolver when Parcel doesn't find anything?
There was a problem hiding this comment.
Yes this falls back to the default sass resolver. Mainly for built-in sass modules.
Tested this with the example repo of #1182 . In this example bootstrap uses mixins which is catched by the sass resolver
|
Awesome, this must be a new feature! I think it will solve a lot of issues, e.g. #39. Let's go through and find other issues related to sass resolution and see if this fixes them too. |
|
@devongovett @DeMoorJasper whats about #1280 ? |
Uses an experimental node-sass feature for overwriting the imports, it seems to be stable and very usefull after some testing
Closes #1182 #39