Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pass compiler of @vue/component-compiler-utils to parser. #1496

Merged
merged 2 commits into from
Jun 7, 2018

Conversation

knight-bubble
Copy link
Contributor

Seems like this bug #1490 appeared, after the change made in this commit vuejs/component-compiler-utils@caa1538#diff-3bebbbb54c7d798b4200eb324ebd4500R17

Tested for older version of vuejs/component-compiler-utils, works pretty fine.

Copy link
Member

@DeMoorJasper DeMoorJasper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you also change vue/component-compiler-utils to be v2 instead of 1 so the CI tests run the latest version (and than users of parcel will also have the latest version as a default)

@codecov-io
Copy link

codecov-io commented Jun 6, 2018

Codecov Report

Merging #1496 into master will decrease coverage by 1.68%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #1496      +/-   ##
=========================================
- Coverage   91.19%   89.5%   -1.69%     
=========================================
  Files          80      80              
  Lines        5975    4403    -1572     
=========================================
- Hits         5449    3941    -1508     
+ Misses        526     462      -64
Impacted Files Coverage Δ
src/assets/VueAsset.js 87.77% <ø> (ø) ⬆️
src/utils/prettyError.js 63.63% <0%> (-36.37%) ⬇️
src/workerfarm/WorkerFarm.js 51.94% <0%> (-33.77%) ⬇️
src/utils/syncPromise.js 57.89% <0%> (-26.32%) ⬇️
src/workerfarm/Worker.js 69.07% <0%> (-25.78%) ⬇️
src/utils/loadPlugins.js 78.57% <0%> (-21.43%) ⬇️
src/visitors/dependencies.js 85.47% <0%> (-10.26%) ⬇️
src/transforms/babel.js 87.96% <0%> (-8.34%) ⬇️
src/assets/HTMLAsset.js 91.83% <0%> (-7.15%) ⬇️
src/workerfarm/errorUtils.js 88.23% <0%> (-5.89%) ⬇️
... and 39 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 24f28bc...4dd1009. Read the comment docs.

@muhlba91
Copy link

is there any ETA for releasing a version containing this fix?

@DeMoorJasper
Copy link
Member

@muhlba91 as soon as the next release comes out, I think Devon has a release planned this week, but I'm not 100% sure

devongovett pushed a commit that referenced this pull request Oct 15, 2018
Seems like this bug #1490 appeared, after the change made in this commit vuejs/component-compiler-utils@caa1538#diff-3bebbbb54c7d798b4200eb324ebd4500R17

Tested for older version of vuejs/component-compiler-utils, works pretty fine.
devongovett pushed a commit that referenced this pull request Oct 15, 2018
Seems like this bug #1490 appeared, after the change made in this commit vuejs/component-compiler-utils@caa1538#diff-3bebbbb54c7d798b4200eb324ebd4500R17

Tested for older version of vuejs/component-compiler-utils, works pretty fine.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants