Fix Sass dependencies can not be watched when includePaths is a relative path #1619
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
devongovett
reviewed
Jun 26, 2018
| path.dirname(this.name) | ||
| ); | ||
| opts.includePaths = (opts.includePaths | ||
| ? opts.includePaths.map(includePath => path.resolve(includePath)) |
There was a problem hiding this comment.
this resolves paths relative to the current working directory. is this right, or do we want to resolve relative to the sass file being compiled?
There was a problem hiding this comment.
Yes, only reative to the current working directory will not change original behavior. It seems that the sass compiler has the same logic for reative path in includePaths.
devongovett
approved these changes
Jun 30, 2018
devongovett
pushed a commit
that referenced
this pull request
Oct 15, 2018
devongovett
pushed a commit
that referenced
this pull request
Oct 15, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For #1613
I have reviewed the contributing guidelines and glad to give a pr to fix it.
Hope this is a suitable solution.