Parcel 2: Default bundle namer #2424
Conversation
| if (bundle.filePath) { | ||
| // TODO: what about multiple assets in the same dep? | ||
| // e.g. input is a Vue file, output is JS + CSS | ||
| // which is defined as a target in package.json? |
There was a problem hiding this comment.
Any ideas how we could tell which one is the main one? Should we take the specified filename and just replace the extension with the bundle type?
| return bundle.filePath; | ||
| } | ||
|
|
||
| // TODO: if split bundle, base name on original bundle names? |
There was a problem hiding this comment.
Any ideas on how to get the information on the original bundles that the split bundle originated from here? I'd rather not add a reference to the original bundles to the bundle object but that may be the only way...
There was a problem hiding this comment.
Only other way I could think of would be to pass in the bundleGraph along with the bundle to be named.
There was a problem hiding this comment.
That could possibly work. The split bundle will be connected to both original bundle groups, but there is currently no way to know which bundle connected to a bundle group was the original one...
| let entryFilePath = entryAsset.filePath; | ||
| let name = path.basename(entryFilePath, path.extname(entryFilePath)); | ||
|
|
||
| // If this is an entry bundle, exclude the hash and use the original relative path. |
There was a problem hiding this comment.
What's the reasoning for this again?
There was a problem hiding this comment.
If you have index.html as an entry point, you typically want to keep that name rather than adding a content hash. Otherwise the link would change every time you deploy. Same thing for things like service workers, where the URL can never change.
Here is the original RFC: #872
This implements bundle naming using namer plugins, and provides the default namer plugin for Parcel 2.
Closes #2240. Fixes #2140.
Summary of changes:
outputHashproperty toAssetwhich is computed at the end of the transformer pipeline. The currenthashproperty is computed after the first transform and is used for caching. TheoutputHashis used for content hashing.