-
-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Parcel 2: Get some JS integration tests passing #2484
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Any clue why the tests are failing on Windows? Other than that and the conflicts it LGTM. |
padmaia
approved these changes
Jan 5, 2019
Maybe multiple tests run in parallel and one test's |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This gets some integration tests for the JS transformer pipeline passing against v2, including babel, fs inlining, node global insertion, environment variable substitution, etc.
Still skipped:
Test changes:
assertBundleTree
withassertBundles
, which asserts against a BundleGraph.--target
cli option with targets in package.json. This caused a few test fixtures to be duplicated in order to change the package.json target.Core changes:
.env
files.require
within atry...catch
block. If they cannot be resolved, they are ignored rather than erroring..browserslistrc
files in TargetResolver along with package.json.parcel-cache
directory before each test. Unlike Parcel 1, we still write to the cache even with--no-cache
, because we don't store the file contents of every asset in memory anymore (the packagers read from the cache).isURL
flag on dependencies, which disables resolution of node_modules for relative paths without a./
prefix. This is typically seen outside of JS, e.g. CSS and HTML, along with some APIs in JS like web workers and service workers. Not totally sure about the naming here, but we can come back to it.