-
-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Parcel 2: Runtime plugins and bundle loader support #2534
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Found some things unrelated to the runtime plugins, but we've discussed those. Otherwise LGTM. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This implements support for runtime plugins in core, and the default runtime plugin for browser/node environments as discussed in #2507. It gets a bunch of the async import integration tests passing.
Runtime plugins are passed a
Bundle
, and can modify it in some way to add assets as needed. For example, the default runtime for JS adds loader runtimes to load bundles on demand for async imports. It will also inject the HMR runtime in the future. Runtime plugins are called in the BundlerRunner just after bundles are created and named, and before packaging.This deviates from the Parcel 2 RFC in that
Loader
plugins are replaced byRuntime
plugins, which are a bit more flexible and easier to implement in a generic way.Note that the interface exposed to runtime plugins to add assets is a hack at the moment and we need to decide where it will go. I will be opening up a separate issue to discuss this and the rest of the AssetGraph/BundleGraph interface that we want to expose to plugins.
Summary of changes
Parcel
into its ownAssetGraphBuilder
class, which can be called to generate an asset graph from anywhere without running the rest of parcel. When watching is enabled,AssetGraphBuilder
emits an event to letParcel
know that something was invalidated, andParcel
rebuilds.code
property to aTransformerRequest
so thatTransformerRunner
uses that code rather than reading from a file.Buffer
,process
, etc.) so that it will not occur if a local variable of the same name is defined. This was happening with importing lodash for example. Probably should also apply this fix to Parcel 1.