Root file shouldn't be hashed. #270
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
All tests passed locally. But one test failed here. Any idea ? |
|
That test just fails from time to time |
devongovett
reviewed
Dec 15, 2017
src/Asset.js
Outdated
| this.options | ||
| ); | ||
|
|
||
| if (this.isMainFile(resolved)) { |
There was a problem hiding this comment.
Can you do this check inside generateBundleName instead of here? Maybe get rid of the boolean parameter all together and replace with this check?
Closed
ssuman
force-pushed
the
rootNotToBeHashed
branch
from
01164f5 to
08f1c61
Compare
|
@devongovett - Changes done. |
devongovett
approved these changes
Dec 20, 2017
devongovett
pushed a commit
that referenced
this pull request
Oct 15, 2018
* This commit should solve the problem of root file being hashed. * This commit will move the isMainFile check within generateBundleName function. * Removing the boolean variable. And using the options variable
devongovett
pushed a commit
that referenced
this pull request
Oct 15, 2018
* This commit should solve the problem of root file being hashed. * This commit will move the isMainFile check within generateBundleName function. * Removing the boolean variable. And using the options variable
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If we have
index.html
-other.html
Other.html
-index.html
In other.html index.html is being replaced with .html. This shouldn't happen.