Add --autoclose to automatically close the browser tab opened b… #3059
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The node 6 tests failed for me before my commit! does anyone know why? |
|
@Taym95 Have you seen this issue? In web worker context the window object is not defined and then causes an error. Also you should bind HMRServer.stop() method to SIGINT signal, otherwise Ctrl + C does not work. |
DeMoorJasper
approved these changes
May 28, 2019
|
feel free to re-open this for v2, gonna close this as v2 is feature locked |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is my first contribution to parcel I tied to fix #3027
↪️ Pull Request
💻 Examples
🚨 Test instructions
✔️ PR Todo