Switch emojis to log-symbols for terminal compatibility #363
Conversation
shawwn
changed the title
|
@brandon93s Ok, I switched out the emojis with log-symbols. It'll be up to @devongovett whether he's fond of the existing hourglass / star emojis though. Alternatively, we could use log-symbols on windows, and the current emojis everywhere else. |
|
Yep.
|
|
yeah let's keep the emojis by default and fall back |
|
Ok, I'll preserve our emoji integrity.
#savemojis
…On Wed, Dec 20, 2017 at 9:12 PM, Devon Govett ***@***.***> wrote:
yeah let's keep the emojis by default and fall back
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#363 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AADo8E79RoNq0UowGMpZCQcMAGUakvyAks5tCcy2gaJpZM4RJPY2>
.
|
There was a problem hiding this comment.
I would recommend some sort of cli-symbols implementation local to parcel that abstracts away all of the platform checks.
It would export a .info, .success, .error, which internally resolves the platform and returns the emoji or the equivalent from log-symbols.
|
Yep, agreed. I just got distracted by holidays and focusing on impactful
work (like abstracting the FS layer). Feel free to submit your own PR if
you get time to tackle this, otherwise I'll eventually get around to it.
…On Thu, Dec 21, 2017 at 10:58 PM, Brandon Smith ***@***.***> wrote:
***@***.**** requested changes on this pull request.
I would recommend some sort of cli-symbols implementation local to parcel
that abstracts away all of the platform checks.
It would export a .info, .success, .error, which internally resolves the
platform and returns the emoji or the equivalent from `log-symbols.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#363 (review)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AADo8FvAQ5ywEjpdMs6uIVkCXrLN-2Wrks5tCzcQgaJpZM4RJPY2>
.
|
devongovett
force-pushed
the
fixes/362/windows-cli-icons
branch
from
fdec330 to
76575bb
Compare
|
Updated to use emoji but have fallback for windows. Apparently VS Code does support emoji though thanks to electron, so we try to detect that. @brandon93s since you use windows, could you verify? Thanks! |
|
@devongovett - great find on the emoji support in VS Code! Windows test outputs below: PowerShell:
CMD:
VSCode (PowerShell):
I've tested failures as well. All three states (processing, success, failure) look good. |
| @@ -0,0 +1,6 @@ | |||
| const supportsEmoji = process.platform !== 'win32' || process.env.VSCODE_PID; | |||
There was a problem hiding this comment.
👍 I like the dedicated utility; should make maintenance easier!
|
Awesome, thanks for testing @brandon93s! Merry Christmas. 🎄 |
|
Same to you! 🎄🎅🏼 |
* Don't show emoji on windows. * Use log-symbols * Emoji with fallback for windows
* Don't show emoji on windows. * Use log-symbols * Emoji with fallback for windows
Closes #362.