Use PARCEL_WORKERS environment variable #589
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #589 +/- ##
==========================================
- Coverage 88.85% 88.81% -0.04%
==========================================
Files 57 57
Lines 1749 1753 +4
==========================================
+ Hits 1554 1557 +3
- Misses 195 196 +1
Continue to review full report at Codecov.
|
fathyb
reviewed
Jan 19, 2018
src/WorkerFarm.js
Outdated
| @@ -97,6 +99,9 @@ for (let key in EventEmitter.prototype) { | |||
| } | |||
|
|
|||
| function getNumWorkers() { | |||
| if (process.env.PARCEL_WORKERS) { | |||
| return parseInt(process.env.PARCEL_WORKERS); | |||
There was a problem hiding this comment.
I recommend you to specify the radix argument, else it'll be infered. Eg. parseInt('0x0101') = 257 while parseInt('0x0101', 10) = 0.
devongovett
approved these changes
Jan 20, 2018
devongovett
pushed a commit
that referenced
this pull request
Oct 15, 2018
* Use PARCEL_WORKERS environment variable * Update WorkerFarm.js
devongovett
pushed a commit
that referenced
this pull request
Oct 15, 2018
* Use PARCEL_WORKERS environment variable * Update WorkerFarm.js
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per the slack convo,
PARCEL_WORKERSenvironment variable controls how many workers to spawn, andPARCEL_WORKERS=0makes all code run on the main thread.PARCEL_WORKERS=0 yarn testruns about 33% faster.