Resolver improvements #6696
Merged
Resolver improvements #6696
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Benchmark ResultsKitchen Sink ✅
Timings
Cold Bundles
Cached Bundles
React HackerNews ✅
Timings
Cold BundlesNo bundle changes detected. Cached BundlesNo bundle changes detected. AtlasKit Editor ✅
Timings
Cold Bundles
Cached Bundles
Three.js ✅
Timings
Cold BundlesNo bundle changes detected. Cached BundlesNo bundle changes detected. |
wbinnssmith
approved these changes
Aug 10, 2021
| @@ -8,7 +8,7 @@ import NodeResolver from '@parcel/node-resolver-core'; | |||
| const WEBPACK_IMPORT_REGEX = /\S+-loader\S*!\S+/g; | |||
|
|
|||
| export default (new Resolver({ | |||
| resolve({dependency, options, filePath}) { | |||
| resolve({dependency, options, specifier}) { | |||
There was a problem hiding this comment.
👍 this name makes so much more sense
mischnic
reviewed
Aug 15, 2021
| @@ -1452,6 +1452,7 @@ export type ResolveResult = {| | |||
| /** An absolute path to the file. */ | |||
| +filePath?: FilePath, | |||
| +pipeline?: ?string, | |||
| +query?: QueryParameters, | |||
There was a problem hiding this comment.
Can you document this? (That these are the query params the resolver didn't handle and should be forwarded to transformers)
| if (!validPipelines.has(pipeline)) { | ||
| // This may be a url protocol or scheme rather than a pipeline, such as | ||
| // `url('http://example.com/foo.png')`. Pass it to resolvers to handle. | ||
| // return {assetGroup: null}; |
There was a problem hiding this comment.
Suggested change
| // return {assetGroup: null}; |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While trying to document the resolver, I came across some inconsistencies and opportunities for improvement.
['ts', 'tsx', 'js', 'jsx', 'json'].?character is allowed in filenames (just not on Windows...).npm:scheme, which allows URL dependencies to resolve tonode_modulespackages rather than as a relative path. Useful for e.g. CSS and web workers. Fixes Support Web Workers coming from node_modules #670. Closes Parcel 2: Specific resolvers per file type #3492.@importdeclarations to the top of the packaged bundle. Fixes CSS @imports are not the first rule in the css output file #5484.filePathoption of resolver plugins tospecifiersince it may include things like query params and URL schemes. Note that this is slightly different fromdependency.specifierin cases where a known named pipeline is used. In this case, thespecifierpassed to resolvers already has the pipeline stripped off.