Update flow to 0.180.0 #8201
Update flow to 0.180.0 #8201
Conversation
| } else if (alias.fileName) { | ||
| alias = alias.fileName; |
There was a problem hiding this comment.
Flow said that this is unreachable type-wise. And this branch was indeed never reached in the tests. So either it really is dead, or we don't test this at all.
Benchmark ResultsKitchen Sink ✅
Timings
Cold Bundles
Cached BundlesNo bundle changes detected. React HackerNews ✅
Timings
Cold BundlesNo bundle changes detected. Cached BundlesNo bundle changes detected. AtlasKit Editor ✅
Timings
Cold BundlesNo bundle changes detected. Cached BundlesNo bundle changes detected. Three.js ✅
Timings
Cold BundlesNo bundle changes detected. Cached BundlesNo bundle changes detected. |
| shouldScopeHoist = false, | ||
| sourceMap, | ||
| loc, | ||
| }: EnvironmentOpts = {...null}, |
There was a problem hiding this comment.
This is weird. What's going on here? All the properties are optional right, so why null?
There was a problem hiding this comment.
This is not about the properties, it's literally only about exact/inexact/unsealed objects: facebook/flow#7424
https://flow.org/try/#0DYUwLgBAHgXBDeAfRBfCBeBKDcAoUkAnnPGpqXgRAF4nJkIB0zAdgK7DA5A
There was a problem hiding this comment.
That's super weird when all the properties are optional. Therefore an empty object should be valid. I guess {...null} has some additional runtime overhead. sigh
There was a problem hiding this comment.
There was a problem hiding this comment.
Alright, {/*:: ...null */} works as well, and doesn't do anything at runtime. I've also replaced all preexisting occurrences of {...null} with the comment version.
...