Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: support parachains without assets pallet in runtime #323

Merged
merged 28 commits into from
Nov 13, 2023

Conversation

marshacb
Copy link
Contributor

@marshacb marshacb commented Nov 10, 2023

  • Handle case when a parachain does not include the Assets pallet in its runtime to allow tx construction instead of throwing an error
  • Refactor ParaTo* direction integration tests and separate into different files
  • Add support for Ethereum AccountKey20 addresses when creating xTokens beneficiaries for ParaToPara direction
  • Rename transferMultiAsset* to transferMultiasset*
  • Replace references to onfinality rpcs with blastapi in ParaTo* examples

closes: #320

package.json Outdated Show resolved Hide resolved
Copy link
Member

@TarikGul TarikGul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll have a closer look at this on Monday. But it looks super solid.

Copy link
Member

@TarikGul TarikGul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, really solid!

I really like the integrationTests abstraction. Makes things way more organized and easier to work through! Just one small question, but good to merge once the conflict is resolved

…d assets pallet validity prior to returning early for parachains that do not support the assets pallet
fix conflicts
refactor ParaToRelay integration tests
@marshacb marshacb merged commit c259cd2 into main Nov 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Default to ATA registry for parachains that don't support the Assets pallet
2 participants