This repository has been archived by the owner on Jun 30, 2022. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: "Draft" while I wait for some ongoing benchmarks to finish before redeploying the bot
Problem
The bot was spotted failing silently recently e.g. in
paritytech/substrate#9018
where it would start the command but never give an actual response of what happened after.
Looking at the logs I see some unknown failures:
Also sometimes shelljs fails
And also a bug introduced by #42
Solution
In this PR we aim to improve error reporting and logging throughout the code while also trying to make it more concise.
Regarding the above library errors, we'll try to counteract by upgrading all third-party dependencies and favoring native Node.js libraries over them where applicable.