Skip to content
This repository has been archived by the owner on Jun 30, 2022. It is now read-only.

add westmint, statemine, statemint runtimes #87

Closed
wants to merge 2 commits into from

Conversation

gilescope
Copy link

necessary but possibly not sufficient

@joao-paulo-parity
Copy link
Contributor

necessary but possibly not sufficient

It's not a big deal if it doesn't work right away as long as it does not breaking existing behavior, you can keep submitting new PRs with improvements and fixes. I'm fine with merging this even if it's not 100% correct (I don't know how to evaluate the commands TBH, hence why I ask for @shawntabrizi 's review here).

@gilescope
Copy link
Author

I think someone has plumbed in benches via the ci now so we can close this.

@gilescope gilescope closed this May 23, 2022
@joao-paulo-parity
Copy link
Contributor

I think someone has plumbed in benches via the ci now so we can close this.

@gilescope To be more precise, the current bench-bot is supposed to be replaced by /cmd queue -c bench-bot $ [args] (https://github.com/paritytech/command-bot#queue) which will work like the current bench-bot (paritytech/polkadot#5478 (comment) for example). We're waiting for https://github.com/paritytech/ci_cd/issues/431 to be done before publicizing the release of command-bot and advocating for its use.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants