This repository has been archived by the owner on Nov 15, 2023. It is now read-only.
Migrate from MQCs in persisted validation data to merkle proofs #317
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
pepyakin
commented
Jan 29, 2021
•
pepyakin
commented
- Run this locally to check if it works
Merged
pepyakin
force-pushed
the
ser-clean-pvd
branch
from
877f007 to
b259a74
Compare
pepyakin
force-pushed
the
ser-clean-pvd
branch
from
b259a74 to
ca992ed
Compare
|
Some changes related to tests were lost somehow. WIP |
|
I cannot test this locally, blocked by paritytech/polkadot#2373 I think we can still review and land this and test the whole thing asynchronously |
bkchr
approved these changes
Feb 8, 2021
| /// If there is no channel, a new default one is created. | ||
| /// | ||
| /// It also updates the `hrmp_ingress_channel_index`, creating it if needed. | ||
| pub fn upsert_inbound_channel(&mut self, sender: ParaId) -> &mut AbridgedHrmpChannel { |
There was a problem hiding this comment.
upsert I needed to google this :D But I also got no better idea.
There was a problem hiding this comment.
Rust uses get_or_insert, here. Perhaps we could use it, but that seemed to me a bit overly long.
There was a problem hiding this comment.
I also thought about this, but it would probably too long as you said.
Co-authored-by: Bastian Köcher <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.