This repository has been archived by the owner on Nov 15, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 379
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jun 10, 2021
@jacogr We'll need a different SignedExtra for the transactions here. |
I would like to merge this PR. |
@bkchr Any objections to merging this? |
bkchr
reviewed
Oct 7, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As far as I can see it looks good.
Note: Will require spec version and transaction bumps when upstreaming Statemine v4 release |
apopiak
commented
Oct 7, 2021
Co-authored-by: Bastian Köcher <[email protected]>
This was referenced Oct 13, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a pallet to allow for transaction payment in assets.
The asset-tx-payment pallet wraps FRAME's transaction-payment pallet and either pays the fees in the native currency if the asset id is set to
None
or in the specified asset.Depends on:
Closes #505
Todos: